Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel: make sure everything existing actually WAI #2021

Closed
deniseli opened this issue Jul 9, 2024 · 3 comments
Closed

otel: make sure everything existing actually WAI #2021

deniseli opened this issue Jul 9, 2024 · 3 comments
Assignees

Comments

@deniseli
Copy link
Contributor

deniseli commented Jul 9, 2024

Code Links:

Out of scope: this logging interface we provide through the Go runtime SDK that no one currently uses: go-runtime/ftl/observability/metrics.go

Datadog:

@github-actions github-actions bot added the triage Issue needs triaging label Jul 9, 2024
@ftl-robot ftl-robot mentioned this issue Jul 9, 2024
@deniseli deniseli mentioned this issue Jul 9, 2024
15 tasks
@gak gak added next Work that will be be picked up next and removed triage Issue needs triaging labels Jul 11, 2024
@deniseli deniseli self-assigned this Jul 16, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 16, 2024
@deniseli
Copy link
Contributor Author

Also part of this: make sure metrics + logs work as intended. Add a toy one, deploy to the dev instance, make some verb calls in the dev instance, and then check datadog to make sure it all pipes all the way through. That unblocks us adding metrics/logs/traces in general.

@deniseli
Copy link
Contributor Author

deniseli commented Aug 5, 2024

Marking this as done now that the correctly parented traces are in prod and the new metrics+attrs are continuing to function as expected

@deniseli deniseli closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants