Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now seeing lots of "context canceled" warnings when a module is reloaded during ftl dev #1956

Closed
alecthomas opened this issue Jul 3, 2024 · 2 comments · Fixed by #1992
Closed
Assignees
Labels
bug Something isn't working P1

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Jul 3, 2024

This only started happening quite recently, I'm not sure why.

warn:runner13: Failed to close stream: canceled: Post "http://localhost:8892/xyz.block.ftl.v1.ControllerService/StreamDeploymentLogs": context canceled
warn:runner13: Failed to close stream: canceled: Post "http://localhost:8892/xyz.block.ftl.v1.ControllerService/RegisterRunner": context canceled
@github-actions github-actions bot added the triage Issue needs triaging label Jul 3, 2024
@ftl-robot ftl-robot mentioned this issue Jul 3, 2024
@worstell worstell added bug Something isn't working P1 next Work that will be be picked up next labels Jul 3, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 3, 2024
@gak gak self-assigned this Jul 5, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 5, 2024
@gak
Copy link
Contributor

gak commented Jul 7, 2024

It was due to fixing a lint of an error that might have intentionally been ignored in the first place: 9941e4b#diff-480fd9ed6d8c8de5875599656b26df5b9d0eca860e33d983b1a151d9337780bbL178

I suspect it is ignored because the connection actually should already be closed, but might need clarification @alecthomas

Going to set the log level to Debug rather that revert the change so we can see the error if we need to debug further.

@alecthomas
Copy link
Collaborator Author

I think logging it at debug is the right call 👍

@gak gak closed this as completed in #1992 Jul 7, 2024
@gak gak closed this as completed in 06b763e Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants