Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass testing.TB into ftltest.Context() so we can provide better errors? #1953

Closed
alecthomas opened this issue Jul 3, 2024 · 1 comment
Closed

Pass testing.TB into ftltest.Context() so we can provide better errors? #1953

alecthomas opened this issue Jul 3, 2024 · 1 comment
Assignees
@alecthomas
Labels
P1

Comments

@alecthomas
Copy link
Collaborator

Currently we just panic() everywhere, but because it's testing we could (possibly, have to be confirmed) pass testing.TB through, and use t.Fatalf() et al to provide useful error messages.
@github-actions github-actions bot added the triage Issue needs triaging label Jul 3, 2024
@alecthomas alecthomas added the P1 label Jul 3, 2024
@ftl-robot ftl-robot mentioned this issue Jul 3, 2024
Open
@worstell worstell added the next Work that will be be picked up next label Jul 3, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 3, 2024
@alecthomas alecthomas self-assigned this Jul 5, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 5, 2024
@alecthomas
Copy link
Collaborator Author

I tried this, but didn't think it added anything significant because things like ftl.Map(), ftl.Secret(), etc. don't have access to the testing instance, so they can only panic.

@alecthomas alecthomas closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecthomas alecthomas

Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @worstell