Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use //ftl:sumtype directive for sumtypes instead of //ftl:enum #1841

Closed
deniseli opened this issue Jun 20, 2024 · 1 comment
Closed

Use //ftl:sumtype directive for sumtypes instead of //ftl:enum #1841

deniseli opened this issue Jun 20, 2024 · 1 comment
Labels
triage Issue needs triaging

Comments

@deniseli
Copy link
Contributor

deniseli commented Jun 20, 2024 •
edited
Loading

Reason: many users aren't familiar with type enums.

Don't change any of the backend schema code - leave that all the same. Just change the directive.
@github-actions github-actions bot added the triage Issue needs triaging label Jun 20, 2024
@deniseli deniseli changed the title Use //ftl:sumtype directive for sumtypes instead of //ftl:enum Use //ftl:sumtype directive for sumtypes instead of //ftl:enum Jun 20, 2024
@ftl-robot ftl-robot mentioned this issue Jun 20, 2024
Open
@gak
Copy link
Contributor

gak commented Jun 20, 2024

Docs and LSP need to be updated for this change too.

@matt2e matt2e closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Issue needs triaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gak @matt2e @deniseli