Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate deploys with ftl dev #1313

Closed
alecthomas opened this issue Apr 19, 2024 · 4 comments
Closed

Duplicate deploys with ftl dev #1313

alecthomas opened this issue Apr 19, 2024 · 4 comments
Labels
bug Something isn't working next Work that will be be picked up next

Comments

@alecthomas
Copy link
Collaborator

Note that after "info: All modules deployed, watching for changes..." modules continue to deploy.

Unfortunately I wasn't able to replicate this with --log-level=trace after this first time.

🐚 ~/dev/ftl-examples $ ftl dev online-boutique --recreate       main
info: Starting FTL with 1 controller(s)
info:currency: Building module
info:ad: Building module
info:cart: Building module
info:ad: Deploying module
info:currency: Deploying module
info:cart: Deploying module
info:payment: Building module
info:productcatalog: Building module
info:shipping: Building module
info:payment: Deploying module
info:shipping: Deploying module
info:recommendation: Building module
info:productcatalog: Deploying module
info:checkout: Building module
info:controller0: Deployed dpl-cart-515hkq3w24griq2m
info:controller0: Deployed dpl-currency-g54syitdsqqgyz2
info:controller0: Deployed dpl-ad-189gw4hgs7glgecp
info:recommendation: Deploying module
info:checkout: Deploying module
info:controller0: Deployed dpl-payment-pc926s88owsim5m
info:controller0: Deployed dpl-shipping-vir6waj51oy7w9y
info:controller0: Deployed dpl-recommendation-ex39lr3bgs5oqdb
info:controller0: Deployed dpl-productcatalog-17flrebfhph4vkjt
info:controller0: Deployed dpl-checkout-17xyauu86aq03wjj
info: All modules deployed, watching for changes...
info:currency: Building module
info:currency: Deploying module
info:controller0: Reusing deployment: dpl-currency-g54syitdsqqgyz2
info:ad: Building module
info:ad: Deploying module
info:controller0: Reusing deployment: dpl-ad-189gw4hgs7glgecp
info:cart: Building module
info:cart: Deploying module
info:controller0: Reusing deployment: dpl-cart-515hkq3w24griq2m
info:productcatalog: Building module
info:productcatalog: Deploying module
info:controller0: Reusing deployment: dpl-productcatalog-17flrebfhph4vkjt
info:shipping: Building module
info:shipping: Deploying module
info:controller0: Reusing deployment: dpl-shipping-vir6waj51oy7w9y
info:payment: Building module
info:payment: Deploying module
info:controller0: Reusing deployment: dpl-payment-pc926s88owsim5m
info:recommendation: Building module
info:recommendation: Deploying module
info:controller0: Reusing deployment: dpl-recommendation-ex39lr3bgs5oqdb
info:checkout: Building module
info:checkout: Deploying module
info:controller0: Reusing deployment: dpl-checkout-17xyauu86aq03wjj
@alecthomas alecthomas added the bug Something isn't working label Apr 19, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Apr 19, 2024
@deniseli deniseli added next Work that will be be picked up next and removed triage Issue needs triaging labels Apr 19, 2024
@matt2e
Copy link
Collaborator

matt2e commented May 8, 2024

Close until we see this again, we think this is fixed with the file change transactions

@matt2e matt2e closed this as completed May 8, 2024
@alecthomas
Copy link
Collaborator Author

I just saw this again, slightly worse this time in that it is building infinitely:

info:echo: Building module
info:time: Deploying module
info:controller0: Reusing deployment: dpl-time-3dh919rt7ionay2u
info:echo: Deploying module
info:controller0: Reusing deployment: dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info: All modules deployed, watching for changes...
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig

@alecthomas alecthomas reopened this May 10, 2024
@alecthomas
Copy link
Collaborator Author

Disregard! I think this was some other bug I introduced.

@matt2e
Copy link
Collaborator

matt2e commented May 12, 2024

Closing again until we see it happen again

@matt2e matt2e closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next Work that will be be picked up next
Projects
None yet
Development

No branches or pull requests

3 participants