From c19246a10eb36d38674714694fdcba4b12e92bde Mon Sep 17 00:00:00 2001 From: Denise Li Date: Tue, 17 Sep 2024 16:11:34 -0400 Subject: [PATCH] fix: console background color scroll bug (#2709) Fixes https://github.com/TBD54566975/ftl/issues/2698 There were actually two underlying issues fixed here: 1. If you hard scroll down on any page in dark mode, the `` element would not respect dark mode, so you could still see white bg underneath. That's gross. It's fixed now in `index.html`. 2. On the infrastructure page specifically, we never set the page body's overflow behavior to scroll, so instead it would overflow the container. Technically, with 1 fixed, you wouldn't even notice this issue, but it was still worth fixing to future-proof the page. --- frontend/console/index.html | 2 +- .../console/src/features/infrastructure/InfrastructurePage.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/console/index.html b/frontend/console/index.html index 240190cc68..a63b1c4d27 100644 --- a/frontend/console/index.html +++ b/frontend/console/index.html @@ -8,7 +8,7 @@ - +
diff --git a/frontend/console/src/features/infrastructure/InfrastructurePage.tsx b/frontend/console/src/features/infrastructure/InfrastructurePage.tsx index 2c652c96a6..3597d08e7a 100644 --- a/frontend/console/src/features/infrastructure/InfrastructurePage.tsx +++ b/frontend/console/src/features/infrastructure/InfrastructurePage.tsx @@ -64,7 +64,7 @@ export const InfrastructurePage = () => { } return ( -
+
{renderTabContent()}