Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New apps are being generated with old dependencies #836

Closed
wKovacs64 opened this issue Apr 23, 2020 · 0 comments · Fixed by blitz-js/blitz#206
Closed

New apps are being generated with old dependencies #836

wKovacs64 opened this issue Apr 23, 2020 · 0 comments · Fixed by blitz-js/blitz#206

Comments

@wKovacs64
Copy link
Contributor

wKovacs64 commented Apr 23, 2020

What is the problem?

Newly generated apps are being populated with the oldest version of dependencies available in the major version range specified in the template rather than the newest.

Steps to Reproduce:

  1. blitz new my-blitz-project
  2. cd my-blitz-project
  3. yarn lint 💥 Oops,

[email protected] is broken. Wait, why do we have 2.0.0 anyway? 2.5.1 is the latest 2.x release.

Versions:

  • Blitz: 0.6.0.-canary.0
  • OS: Windows 10 and macOS
debug: local
debug: pkgPath: C:\dev\test\my-blitz\node_modules\@blitzjs\cli

env: win32-x64 node-v12.16.1
blitz: 0.6.0-canary.0 (global)
blitz: 0.6.0-canary.0 (local)

Supporting Documentation

> blitz new my-broken-blitz
> cd my-broken-blitz
> yarn lint

$ eslint --ignore-path .gitignore --ext .js,.ts,.tsx .
Error: Failed to load plugin 'react-hooks' declared in '.eslintrc.js » eslint-config-react-app': Cannot find module './src/index'
Require stack:
- C:\dev\test\my-broken-blitz\node_modules\eslint-plugin-react-hooks\index.js
- C:\dev\test\my-broken-blitz\node_modules\eslint\lib\cli-engine\config-array-factory.js
- C:\dev\test\my-broken-blitz\node_modules\eslint\lib\cli-engine\cascading-config-array-factory.js
- C:\dev\test\my-broken-blitz\node_modules\eslint\lib\cli-engine\cli-engine.js
- C:\dev\test\my-broken-blitz\node_modules\eslint\lib\cli-engine\index.js
- C:\dev\test\my-broken-blitz\node_modules\eslint\lib\cli.js
- C:\dev\test\my-broken-blitz\node_modules\eslint\bin\eslint.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:982:15)
    at Function.Module._load (internal/modules/cjs/loader.js:864:27)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
    at require (C:\dev\test\my-broken-blitz\node_modules\v8-compile-cache\v8-compile-cache.js:161:20)
    at Object.<anonymous> (C:\dev\test\my-broken-blitz\node_modules\eslint-plugin-react-hooks\index.js:10:18)
    at Module._compile (C:\dev\test\my-broken-blitz\node_modules\v8-compile-cache\v8-compile-cache.js:194:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
    at Module.load (internal/modules/cjs/loader.js:1002:32)
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

> yarn outdated

Package                   Current                      Wanted                       Latest  Package Type    URL
eslint-plugin-react-hooks 2.0.0                        2.0.0                        3.0.0   devDependencies https://reactjs.org/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants