Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable React Fast Refresh #794

Closed
merelinguist opened this issue Apr 28, 2020 · 7 comments · Fixed by blitz-js/blitz#435
Closed

Enable React Fast Refresh #794

merelinguist opened this issue Apr 28, 2020 · 7 comments · Fixed by blitz-js/blitz#435

Comments

@merelinguist
Copy link
Contributor

merelinguist commented Apr 28, 2020

What do you want and why?

We should enable Fast Refresh for apps by default.

Implementation

  1. Add the fastRefresh flag inside the withBlitz config wrapper
  experimental: {
    reactRefresh: true
  }
  1. Upgrade Next.js to latest canary (>= 9.3.7-canary.5)

See here for an explanation: vercel/next.js#12008

@Timer
Copy link

Timer commented Apr 28, 2020

This feature is not ready to be enabled by default. Please do not enable it for all users until (at a minimum) vercel/next.js#12222 has been landed.

@merelinguist
Copy link
Contributor Author

@Timer Oh, okay! I saw a tweet from Dan asking people to try it out so I assumed it was at least alpha-ready. Thanks so much for the heads up 👍

@Timer
Copy link

Timer commented Apr 28, 2020

@flybayer
Copy link
Member

Thanks @Timer!

Reopening this because we still want to do it at some point

@flybayer flybayer reopened this Apr 29, 2020
@Timer
Copy link

Timer commented May 2, 2020

Good to enable now if the underlying Next version is ^9.3.7-canary.5 or newer.

@flybayer
Copy link
Member

flybayer commented May 2, 2020

Awesome, thank you @Timer!!

@simondebbarma
Copy link
Contributor

Thank you very much, @dwightwatson !

@itsdillon itsdillon transferred this issue from blitz-js/blitz Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants