Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likelihood bounds for heldout set in time mode are always 0.0 #18

Open
muellermarkus opened this issue Aug 16, 2021 · 0 comments
Open

Comments

@muellermarkus
Copy link

For any given heldout set, the heldout_post.dat file shows a 0.0 likelihood bound for each document. The issue appears to stem from the code referenced below. Instead of saving the previously calculated likelihood variable to the table, the log_likelihood from the doc_t struct is saved, which is initialised to 0.0 in data.c.

dtm/dtm/main.c

Line 277 in 810d9ab

table[t][d] = post.doc->log_likelihood;

To solve this problem, I propose to simply use table[t][d] = likelihood;.

@muellermarkus muellermarkus changed the title log-likelihoods for heldout set in time mode are always 0.0 likelihood bounds for heldout set in time mode are always 0.0 Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant