Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub unsub #604

Open
WuglyakBolgoink opened this issue Feb 1, 2024 · 1 comment
Open

sub unsub #604

WuglyakBolgoink opened this issue Feb 1, 2024 · 1 comment

Comments

@WuglyakBolgoink
Copy link

this.sub.add(
this.buildsService.jobEvents().subscribe((ev: SocketEvent) => this.updateJobFromEvent(ev))
);
this.sub.add(
this.buildsService
.jobLogEvents()
.subscribe((ev: SocketEvent) => this.updateJobLogFromEvent(ev))
);

Why you need this part if you use @ngneat/until-destroy package?

@jkuri
Copy link
Contributor

jkuri commented Feb 1, 2024

I think this was used before we included @UntilDestroy() decorator, as you can see this two subscriptions doesn't use untilDestroy(this) operator...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants