Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/indicators): remove support for key info layout string type #587

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Blackbaud-ErikaMcVey
Copy link
Contributor

@Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey commented Sep 28, 2022

BREAKING CHANGE: This change updates the types accepted by the key info component's layout property. To address this change, only pass 'horizontal' or 'vertical' to the property, and use the
type SkyKeyInfoLayoutType if typing variables.

@nx-cloud
Copy link

nx-cloud bot commented Sep 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6bd2e48. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 24 targets

Sent with 💌 from NxCloud.

…g type

BREAKING CHANGE: This change updates the types accepted by the key info component's layout property. To address this change, only pass 'horizontal' or 'vertical' to the property, and use the type `SkyKeyInfoLayoutType` if typing variables.
@Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey merged commit ffac254 into main Sep 28, 2022
@Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey deleted the update-key-info-layout-type branch September 28, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants