Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/modals): modal host sets initial modal focus to avoid race condition #2944

Merged
merged 5 commits into from
Dec 13, 2024
Merged

fix(components/modals): modal host sets initial modal focus to avoid race condition #2944

merged 5 commits into from
Dec 13, 2024
+115 −95

Conversation

Blackbaud-TrevorBurch
Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch commented Dec 11, 2024 •
edited by azure-boards bot
Loading

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch added the risk level (author): 3 This change has a moderate chance of introducing a bug label Dec 11, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 11, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8e18af4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@blackbaud-sky-build-user
Copy link
Collaborator

Storybook preview

Component Storybooks:

Apps:

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch marked this pull request as draft December 11, 2024 02:31
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch marked this pull request as ready for review December 11, 2024 02:54
@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Dec 11, 2024
@Blackbaud-SteveBrush Blackbaud-SteveBrush enabled auto-merge (squash) December 13, 2024 16:12
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit dfdd548 into main Dec 13, 2024
104 checks passed
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the modal-host-set-focus branch December 13, 2024 16:20
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-SteveBrush Blackbaud-SteveBrush Blackbaud-SteveBrush approved these changes

Assignees

@Blackbaud-SteveBrush Blackbaud-SteveBrush

Labels
risk level (author): 3 This change has a moderate chance of introducing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blackbaud-TrevorBurch @blackbaud-sky-build-user @Blackbaud-SteveBrush @johnhwhite