Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components/lookup): add test harnesses to country field #2822

Merged
merged 7 commits into from
Oct 16, 2024
Merged

feat(components/lookup): add test harnesses to country field #2822

merged 7 commits into from
Oct 16, 2024

Conversation

Blackbaud-CoreyArcher
Copy link
Contributor

@Blackbaud-CoreyArcher Blackbaud-CoreyArcher commented Oct 11, 2024 •
edited by azure-boards bot
Loading

@Blackbaud-CoreyArcher Blackbaud-CoreyArcher added the risk level (author): 1 No additional bugs expected from this change label Oct 11, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 11, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4ee71a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@blackbaud-sky-build-user
Copy link
Collaborator

Storybook preview

Component Storybooks:

  • (no component storybooks affected in this pr)

Apps:

@Blackbaud-CoreyArcher Blackbaud-CoreyArcher marked this pull request as ready for review October 11, 2024 19:05
Blackbaud-SandhyaRajasabeson
Blackbaud-SandhyaRajasabeson reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your PR title says layout when it should be lookup

...components/lookup/testing/src/country-field/fixtures/country-field-harness-test.component.ts Show resolved Hide resolved
libs/components/lookup/testing/src/country-field/country-field-harness.ts Show resolved Hide resolved
libs/components/lookup/testing/src/country-field/country-field-harness.ts Outdated Show resolved Hide resolved
libs/components/lookup/testing/src/country-field/country-field-harness.ts Show resolved Hide resolved
libs/components/lookup/testing/src/country-field/country-field-harness.ts Outdated Show resolved Hide resolved
libs/components/lookup/testing/src/country-field/country-field-search-result-harness.ts Show resolved Hide resolved
@Blackbaud-CoreyArcher Blackbaud-CoreyArcher changed the title feat(components/layout): add test harnesses to country field feat(components/lookup): add test harnesses to country field Oct 16, 2024
@Blackbaud-CoreyArcher Blackbaud-CoreyArcher enabled auto-merge (squash) October 16, 2024 14:23
@Blackbaud-CoreyArcher Blackbaud-CoreyArcher merged commit a5df333 into main Oct 16, 2024
24 checks passed
@Blackbaud-CoreyArcher Blackbaud-CoreyArcher deleted the country-field-harness branch October 16, 2024 16:41
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Oct 16, 2024
Merged
johnhwhite added a commit that referenced this pull request Oct 16, 2024
@johnhwhite
Merge remote-tracking branch 'origin/main' into fix-page-links-size
1eefe8f 
* origin/main:
  feat(components/lookup): add test harnesses to country field (#2822)
johnhwhite added a commit that referenced this pull request Oct 16, 2024
@johnhwhite
Merge remote-tracking branch 'origin/main' into home-page-blocks-layo…
193c484 
…ut-demo

* origin/main:
  fix(components/pages): constrain page sizing (#2832)
  feat(components/lookup): add test harnesses to country field (#2822)
  fix(components/packages): accommodate vscode settings with json comments (#2833)
  feat(components/forms): tokenize input box styling (#2811)
  feat(components/theme): tokenize button styling (#2803)
  chore: release 11.11.2 (#2829)
  ci: adjust ci pipeline for fork pull requests (#2830)

# Conflicts:
#	libs/components/theme/src/lib/styles/_layout-host.scss
johnhwhite pushed a commit that referenced this pull request Oct 16, 2024
@blackbaud-sky-build-user
chore: release 11.12.0 (#2831)
9116ffb 
🤖 I have created a release *beep* *boop*
---


##
[11.12.0](11.11.2...11.12.0)
(2024-10-16)


### Features

* **components/forms:** tokenize input box styling
([#2811](#2811))
([30e0304](30e0304))
* **components/lookup:** add test harnesses to country field
([#2822](#2822))
([a5df333](a5df333))
* **components/theme:** tokenize button styling
([#2803](#2803))
([f319508](f319508))


### Bug Fixes

* **components/packages:** accommodate vscode settings with json
comments ([#2833](#2833))
([be34b8d](be34b8d))
* **components/pages:** constrain page sizing
([#2832](#2832))
([e89fb87](e89fb87))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackbaud-johnly blackbaud-johnly blackbaud-johnly left review comments

@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson approved these changes

Assignees

@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson

Labels
risk level (author): 1 No additional bugs expected from this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blackbaud-CoreyArcher @blackbaud-sky-build-user @blackbaud-johnly @Blackbaud-SandhyaRajasabeson