Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples-common project is added when BGFX_BUILD_EXAMPLES option is turned off. #224

Closed
JimmyLord opened this issue Apr 16, 2024 · 1 comment · Fixed by #225
Closed

examples-common project is added when BGFX_BUILD_EXAMPLES option is turned off. #224

JimmyLord opened this issue Apr 16, 2024 · 1 comment · Fixed by #225

Comments

@JimmyLord
Copy link

When adding bgfx to a new cmake project using the following:

option(BGFX_BUILD_TOOLS "" OFF)
option(BGFX_BUILD_EXAMPLES "" OFF)
option(BGFX_BUILD_TESTS "" OFF)
option(BGFX_INSTALL "" OFF)
option(BGFX_CUSTOM_TARGETS "" OFF)
add_subdirectory("Libraries/bgfx.cmake")

The examples-common project is still added to my solution.

This can be fixed by wrapping add_example( common ... ... ... ) in a if(BGFX_BUILD_EXAMPLES) block in the examples.cmake file.
@JimmyLord JimmyLord mentioned this issue Apr 16, 2024
Merged
@bwrsandman
Copy link
Collaborator

It's not only examples that link with examples common. Shaderc is in tools as one example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ew option to allow "example-common" project to not be included in build. JimmyLord/bgfx.cmake
2 participants
@bwrsandman @JimmyLord