Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default_title from parameter first, then original_title #1

Open
johandouma opened this issue Jun 11, 2011 · 1 comment
Open

Use default_title from parameter first, then original_title #1

johandouma opened this issue Jun 11, 2011 · 1 comment

Comments

@johandouma
Copy link

Hi all,

I'm not sure if this is a bug or a feature request...

// use SEO title over original if it exists, then original, then default_title from parameter
'title' => htmlspecialchars($this->get_preferred_value($seolite_entry->seo_title, $seolite_entry->original_title, $default_title), ENT_QUOTES)

If an entry is required, then the original_title will be defined no matter what. But if there isn't any entry, then in most cases, a 404 page is loaded or an alternative entry is displayed, in that case seo_lite won't be used.
On pages listing entries, instead of being the en entrie's page, then I set the title, description and rel=can manually instead of using seo_lite.
So I don't really see the point in having the default_title param as last option... In which cases could it be used?

Now, if the two last params are swapped around, setting the default_title param in the template would allow us to overide the original title with a custom title on a per template basis.
For example

{title} {if categories} | {category_name}{categories} | News Section | {site_name}

As far as I can see, this would be a great improvement.

Johan

@bjornbjorn
Copy link
Owner

default title is used in conjunction with use_last_segment and a global embedets, see "the ultimate setup" in the docs. I'm travelling right now but have added looking through this request to my todolist for the next release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants