[SM-865] Part 2 Use new get secrets by IDs endpoint #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Thomas-Avery
changed the title
Thomas-Avery
changed the title
dani-garcia
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Looks pretty good on quick review, nice work! Just got a couple of comments:
- Please update the changelog inside the bitwarden crate to mention this PR on the unreleased section
- We're trying as much as we can to keep PRs small, and the autogenerated bindings definitely don't make this easy 😅, would you mind extracting the autogenerated bindings to a separate PR, which we can get merged quickly, and just keeping this one for the secrets changes? Thanks!
crates/bitwarden-napi/binding.js
Outdated
| @@ -11,7 +11,8 @@ function isMusl() { | |||
| // For Node 10 | |||
| if (!process.report || typeof process.report.getReport !== "function") { | |||
| try { | |||
| return readFileSync("/usr/bin/ldd", "utf8").includes("musl"); | |||
| const lddPath = require("child_process").execSync("which ldd").toString().trim(); | |||
| return readFileSync(lddPath, "utf8").includes("musl"); | |||
There was a problem hiding this comment.
The changes to this file don't seem related to this PR, can we move it to a separate PR with some explanation on why they are needed?
There was a problem hiding this comment.
This file is auto generated when running npm run build in the napi crate.
Looks like my M1 Macbook generates a different file for both master and this branch.
I'm reverting it back 143cd6e to what is in master.
In the future, this probably should be built during the build/release workflows and not handled by source control.
Thomas-Avery
changed the title
Thomas-Avery
dismissed
dani-garcia’s stale review
The base branch was changed.
dani-garcia
approved these changes
Aug 28, 2023
5 tasks
tangowithfoxtrot
added a commit
that referenced
this pull request
Feb 29, 2024
## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective Allow secret fetching by a list of IDs, rather than requesting multiple secrets individually. Exposes the functionality from #150 in Go. ## Code changes - **languages/go/secrets.go:** Add `GetByIDS` func. - **languages/go/example/example.go:** Get secrets by ID. Added JSON output for QA/ease-of-use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The purpose of this PR is to expose the new get secrets by IDs endpoint in the SDK and use that in the bws CLI and napi.
Code changes
crates/bitwarden-json/src/client.rs:
crates/bitwarden-json/src/command.rs:
Exposing
GetByIdsas a secret command.crates/bitwarden-napi/src-ts/bitwarden_client/index.ts:
Exposing
getByIdsin typescript/ napi-rs implementation.crates/bitwarden/src/secrets_manager/client_secrets.rs:
crates/bitwarden/src/secrets_manager/secrets/get_by_ids.rs:
crates/bitwarden/src/secrets_manager/secrets/mod.rs:
Source code for
get_by_idssecret command.crates/bitwarden/src/secrets_manager/secrets/secret_response.rs:
Add support for parsing the
BaseSecretResponseModeland createSecretsResponsefor returning a vec of SecretResponses.crates/bws/src/main.rs:
Use
get_by_idsin bws secret listing command instead of individually making an HTTP request for each secret.crates/sdk-schemas/src/main.rs:
Add
SecretsResponseas a result of SDK command.Screenshots
Before you submit