From 37b22fef050fb7b6556c66846e318812c4c88fe2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ch=C4=99ci=C5=84ski?= Date: Thu, 17 Oct 2024 16:15:54 +0200 Subject: [PATCH] [BRE-101] Remove dept-devops from CODEOWNERS (#826) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## 🎟ī¸ Tracking https://bitwarden.atlassian.net/browse/BRE-101 ## 📔 Objective Remove dept-devops from CODEOWNERS and add `bitwarden/dept-bre` for all release workflows. ## 📸 Screenshots ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## đŸĻŽ Reviewer guidelines - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹī¸ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠ī¸ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or â™ģī¸ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --------- Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com> Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com> --- .github/CODEOWNERS | 44 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e4fbb97b9..2698af85c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,9 +4,43 @@ # # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners +# BRE for publish workflow changes +.github/workflows/publish-*.yml @bitwarden/dept-bre + +# Shared workflows ownership + +## BRE & SM teams shared ownership +.github/workflows/build-cli-docker.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-cli.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-python-wheels.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/build-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-bws.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-python.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev +.github/workflows/release-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev + +## Multiple owners +.github/workflows/build-android.yml +.github/workflows/build-rust-crates.yml +.github/workflows/build-rust-cross-platform.yml +.github/workflows/build-swift.yml +.github/workflows/build-wasm-internal.yml +.github/workflows/build-wasm.yml +.github/workflows/release-rust-crates.yml +.github/workflows/release-swift.yml +.github/workflows/release-wasm.yml +.github/workflows/version-bump.yml + -# DevOps for Actions and other workflow changes. -.github/workflows @bitwarden/dept-devops # Secrets Manager team crates/bitwarden-sm @bitwarden/team-secrets-manager-dev @@ -16,3 +50,9 @@ crates/bws @bitwarden/team-secrets-manager-dev crates/bws/Cargo.toml crates/bws/scripts/install.ps1 crates/bws/scripts/install.sh + +## Docker files have shared ownership ## +**/Dockerfile +**/*.Dockerfile +**/.dockerignore +**/entrypoint.sh