Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-524] Ignore flaky elements in Chromatic tests #12561

Merged
merged 13 commits into from
Dec 30, 2024

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Dec 23, 2024

🎟️ Tracking

CL-524

📔 Objective

We're seeing some frequent and noisy Chromatic diffs for stories that have no changes.

For the kitchen sink stories, it is usually the menu component being positioned ~1px lower or higher than the previous build, or the virtual scroll story showing more or less rows of data in the screenshot. These are not actual useful diffs, so this PR is going to try to ignore the elements that are causing the diffs while keeping the stories around.

For the popup layout stories, we are still working on debugging why sometimes the snapshots include all the item info, and sometimes they don't. The Storybook live instance consistently shows all the item info as expected, so it is an issue with how the snapshots are getting taken. While we work to figure this out, we are disabling the tests entirely so that developers are not constantly seeing diffs to these stories.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Logo
Checkmarx One – Scan Summary & Detailsb56b377d-881b-436a-95f3-c140cf4e2de5

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 15

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.78%. Comparing base (7deba63) to head (9564bdd).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12561   +/-   ##
=======================================
  Coverage   33.78%   33.78%           
=======================================
  Files        2912     2912           
  Lines       90747    90747           
  Branches    17165    17165           
=======================================
  Hits        30655    30655           
  Misses      57703    57703           
  Partials     2389     2389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vleague2 vleague2 marked this pull request as ready for review December 30, 2024 19:48
@vleague2 vleague2 requested a review from a team as a code owner December 30, 2024 19:48
@vleague2 vleague2 requested review from willmartian and merissaacosta and removed request for willmartian December 30, 2024 19:48
@vleague2 vleague2 merged commit a95427e into main Dec 30, 2024
75 checks passed
@vleague2 vleague2 deleted the uif/cl-524/chromatic-ignores branch December 30, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants