-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL-524] Ignore flaky elements in Chromatic tests #12561
Merged
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12561 +/- ##
=======================================
Coverage 33.78% 33.78%
=======================================
Files 2912 2912
Lines 90747 90747
Branches 17165 17165
=======================================
Hits 30655 30655
Misses 57703 57703
Partials 2389 2389 ☔ View full report in Codecov by Sentry. |
vleague2
requested review from
willmartian and
merissaacosta
and removed request for
willmartian
December 30, 2024 19:48
merissaacosta
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
CL-524
📔 Objective
We're seeing some frequent and noisy Chromatic diffs for stories that have no changes.
For the kitchen sink stories, it is usually the menu component being positioned ~1px lower or higher than the previous build, or the virtual scroll story showing more or less rows of data in the screenshot. These are not actual useful diffs, so this PR is going to try to ignore the elements that are causing the diffs while keeping the stories around.
For the popup layout stories, we are still working on debugging why sometimes the snapshots include all the item info, and sometimes they don't. The Storybook live instance consistently shows all the item info as expected, so it is an issue with how the snapshots are getting taken. While we work to figure this out, we are disabling the tests entirely so that developers are not constantly seeing diffs to these stories.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes