From a56016c4fc223a3ebeb992704da8d9f43d473520 Mon Sep 17 00:00:00 2001 From: Opeyemi Alao <54288773+Eeebru@users.noreply.github.com> Date: Mon, 7 Oct 2024 16:31:15 +0100 Subject: [PATCH 1/5] update mas hardened runtime to true --- apps/desktop/electron-builder.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/desktop/electron-builder.json b/apps/desktop/electron-builder.json index be30e063c1a..e5672bbdf7f 100644 --- a/apps/desktop/electron-builder.json +++ b/apps/desktop/electron-builder.json @@ -141,7 +141,7 @@ "entitlements": "resources/entitlements.mas.plist", "entitlementsInherit": "resources/entitlements.mas.inherit.plist", "entitlementsLoginHelper": "resources/entitlements.mas.loginhelper.plist", - "hardenedRuntime": false, + "hardenedRuntime": true, "extendInfo": { "LSMinimumSystemVersion": "12", "ElectronTeamID": "LTZ2PFU5D6" From 8dabbd4ca44a5c5cb5647624bb99521440fd6b73 Mon Sep 17 00:00:00 2001 From: Opeyemi Alao <54288773+Eeebru@users.noreply.github.com> Date: Mon, 7 Oct 2024 16:47:05 +0100 Subject: [PATCH 2/5] comment testflight and slack notif branch checks --- .github/workflows/build-desktop.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build-desktop.yml b/.github/workflows/build-desktop.yml index 5022184bd05..3a4cb3b8f42 100644 --- a/.github/workflows/build-desktop.yml +++ b/.github/workflows/build-desktop.yml @@ -1033,10 +1033,10 @@ jobs: - name: Deploy to TestFlight id: testflight-deploy - if: | - (github.ref == 'refs/heads/main' - || github.ref == 'refs/heads/rc' - || github.ref == 'refs/heads/hotfix-rc-desktop') + # if: | + # (github.ref == 'refs/heads/main' + # || github.ref == 'refs/heads/rc' + # || github.ref == 'refs/heads/hotfix-rc-desktop') env: APP_STORE_CONNECT_TEAM_ISSUER: ${{ secrets.APP_STORE_CONNECT_TEAM_ISSUER }} APP_STORE_CONNECT_AUTH_KEY: 6TV9MKN3GP @@ -1050,10 +1050,10 @@ jobs: - name: Post message to a Slack channel id: slack-message - if: | - (github.ref == 'refs/heads/main' - || github.ref == 'refs/heads/rc' - || github.ref == 'refs/heads/hotfix-rc-desktop') + # if: | + # (github.ref == 'refs/heads/main' + # || github.ref == 'refs/heads/rc' + # || github.ref == 'refs/heads/hotfix-rc-desktop') uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0 with: channel-id: C074F5UESQ0 From 39efe243f2600e743be65789d8921331428b1f88 Mon Sep 17 00:00:00 2001 From: Opeyemi Alao <54288773+Eeebru@users.noreply.github.com> Date: Fri, 27 Dec 2024 12:41:31 +0000 Subject: [PATCH 3/5] add more entitlement permissions --- .../resources/entitlements.desktop_proxy.inherit.plist | 4 ++++ apps/desktop/resources/entitlements.desktop_proxy.plist | 4 ++++ apps/desktop/resources/entitlements.mas.inherit.plist | 2 +- apps/desktop/resources/entitlements.mas.plist | 4 ++++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/apps/desktop/resources/entitlements.desktop_proxy.inherit.plist b/apps/desktop/resources/entitlements.desktop_proxy.inherit.plist index 794eada1cad..3ba8706380d 100644 --- a/apps/desktop/resources/entitlements.desktop_proxy.inherit.plist +++ b/apps/desktop/resources/entitlements.desktop_proxy.inherit.plist @@ -6,5 +6,9 @@ com.apple.security.inherit + com.apple.security.cs.allow-jit + + com.apple.security.cs.allow-unsigned-executable-memory + diff --git a/apps/desktop/resources/entitlements.desktop_proxy.plist b/apps/desktop/resources/entitlements.desktop_proxy.plist index d5c7b8a2cc8..7f77c55f4fd 100644 --- a/apps/desktop/resources/entitlements.desktop_proxy.plist +++ b/apps/desktop/resources/entitlements.desktop_proxy.plist @@ -8,5 +8,9 @@ LTZ2PFU5D6.com.bitwarden.desktop + com.apple.security.cs.allow-jit + + com.apple.security.cs.allow-unsigned-executable-memory + diff --git a/apps/desktop/resources/entitlements.mas.inherit.plist b/apps/desktop/resources/entitlements.mas.inherit.plist index 7e1674a8f16..3dd68db614e 100644 --- a/apps/desktop/resources/entitlements.mas.inherit.plist +++ b/apps/desktop/resources/entitlements.mas.inherit.plist @@ -8,7 +8,7 @@ com.apple.security.cs.allow-unsigned-executable-memory - com.apple.security.cs.disable-library-validation + com.apple.security.cs.allow-jit