Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Deps Not Included in package-lock.json #13350

Open
1 task done
howyay opened this issue Feb 11, 2025 · 1 comment
Open
1 task done

Optional Deps Not Included in package-lock.json #13350

howyay opened this issue Feb 11, 2025 · 1 comment
Labels
bug desktop Desktop Application

Comments

@howyay
Copy link

howyay commented Feb 11, 2025

Steps To Reproduce

On a none-darwin-arm64 system (because @esbuild/darwin-x64 is included in package-lock.json):

  1. Prefetch node dependencies using information from package-lock.json
  2. Build using npm with offline mode and from prefetched caches
  3. Encounter failure due to missing @esbuild/{platform} in the cache.

Expected Result

All platform specific optional dependencies be present in package-lock.json for reproducible builds.

Actual Result

Starting from 2025.1.2, and likely due to an upstream bug npm/cli#4828, platform specific optional dependencies, e.g. @esbuild/linux-x64 are not locked in package-lock.json, preventing downstream packaging (namely Nix in my case) from working correctly.

In the meantime, it seems that the correct, complete package-lock.json can be generated by purging node_modules and package-lock.json and then running npm run build

Screenshots or Videos

No response

Additional Context

No response

Operating System

Linux

Operating System Version

No response

Installation method

Other

Build Version

2025.1.2

Issue Tracking Info

  • I understand that work is tracked outside of GitHub. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@howyay howyay added bug desktop Desktop Application labels Feb 11, 2025
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-18197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug desktop Desktop Application
Projects
None yet
Development

No branches or pull requests

2 participants