fido2-page-script-delay-append-mv2.js still breaking styles in Firefox #11428
Comments
|
Hi there, Thank you for your report! I was able to reproduce this issue, and I have flagged this to our engineering team. If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these. Thanks once again! |
|
Resolved with the changed from #11444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps To Reproduce
This affects screens in a commercial web application I maintain. I can provide testing credentials to project maintainers. Tested in Firefox, 2024.9.1.
Expected Result
tags should not be removed from the page by the extensionActual Result
Some and <style /> tags, which are not managed by the extension, are removed from the page.
Screenshots or Videos
Additional Context
Part of the issue is that the document.head element doesn't exist at the time
fido2-page-script-delay-append-mv2.jsexecutes.This causes the
<script />tag to be created as the first child under<html />, and remain there for most of the page load.The module loading framework that we use expects document.documentElement[0] to be document.head. This results in
<link />and<script />tags being inserted into the fido2 script tag, which are then removed when the script tag is deleted.This is related to #10830 and #11304. Although I'm testing in the current version (2024.9.1), it looks like the code in the main branch is still susceptible to this.
Operating System
Windows, macOS, Linux
Operating System Version
No response
Web Browser
Firefox
Browser Version
No response
Build Version
2024.9.1
Issue Tracking Info
The text was updated successfully, but these errors were encountered: