Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2][manikey123] Ensure back end API changes reflected to front end based on config file updates #2406

Open
manikey123 opened this issue Jan 15, 2019 · 7 comments
Labels
[0] Awaits Core Imp. Notification that this issue requies additional core functionality. [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours [6] Core Impact flag identifying related to bitshares-core [7] Estimated Administration flag, notifies hours are estimated and requires revisiting

Comments

@manikey123
Copy link
Contributor

manikey123 commented Jan 15, 2019

Is your feature request related to a problem? Please describe.
Backend changes to config ini is being made and its reflection to frontend needs to be evaluated/fixed. Will be better placed to work / update this ticket once the core tickets complete ( around February)
Describe the solution you'd like
Inspired from core ticket : 782, 783
bitshares/bitshares-core#782
bitshares/bitshares-core#783

Some API's under scope ( will revist this list once core tickets are pushed):
get_grouped_limit_orders
get_asset_holders_count
get_asset_holders
get_account_history_by_operations
get_relative_account_history
get_fill_order_history
get_key_references
get_limit_orders,
get_call_orders,
get_settle_orders
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Based on backend changes
Additional context
Add any other context or screenshots about the feature request here.
image

image

@manikey123 manikey123 changed the title Ensure back end changes reflected to front end Ensure back end API changes reflected to front end based on config file Jan 15, 2019
@manikey123
Copy link
Contributor Author

claiming this. this would be available in February to evaluate.

@manikey123 manikey123 changed the title Ensure back end API changes reflected to front end based on config file Ensure back end API changes reflected to front end based on config file updates Jan 15, 2019
@startailcoon startailcoon added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [6] Core Impact flag identifying related to bitshares-core [5c] Medium Indicates size of task. Est. between two and four hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Jan 21, 2019
@startailcoon startailcoon changed the title Ensure back end API changes reflected to front end based on config file updates [2] Ensure back end API changes reflected to front end based on config file updates Jan 21, 2019
@startailcoon startailcoon changed the title [2] Ensure back end API changes reflected to front end based on config file updates [2][manikey123] Ensure back end API changes reflected to front end based on config file updates Jan 21, 2019
@startailcoon
Copy link
Contributor

@manikey123 I've added 2 hours to this task. Please ping if your estimates are larger

@startailcoon
Copy link
Contributor

@manikey123 any progress on the issue?

@startailcoon startailcoon added this to the 190301 milestone Feb 15, 2019
@manikey123
Copy link
Contributor Author

@manikey123 any progress on the issue?

Core 782 , 783 is under code review and minor iterations are expected. this is part of april milestone release. so estimate would be meaningful around then. if anything changes will keep you posted.

@clockworkgr clockworkgr modified the milestones: 190301, 190412 Mar 6, 2019
@startailcoon startailcoon modified the milestones: 190412, 190426 Apr 14, 2019
@clockworkgr clockworkgr modified the milestones: 190426, 190510 May 4, 2019
@startailcoon
Copy link
Contributor

startailcoon commented May 22, 2019

Update

@startailcoon startailcoon added the [0] Awaits Core Imp. Notification that this issue requies additional core functionality. label May 22, 2019
@startailcoon startailcoon modified the milestones: 190510, 190607 May 22, 2019
@clockworkgr clockworkgr modified the milestones: 190607, 190705 Jun 28, 2019
@startailcoon startailcoon modified the milestones: 190705, 190719 Jul 16, 2019
@clockworkgr clockworkgr modified the milestones: 190719, 190802 Jul 23, 2019
@startailcoon
Copy link
Contributor

Merged with bitshares/bitshares-core#1673. @manikey123 what's your opinion, are we done?

@manikey123
Copy link
Contributor Author

currently there is dependency on completion of Core tickets :

  1. Incentivizing Node API operators (premium endpoint service for clients) bitshares-core#1882 (point 5 in "Common parts for all three above approaches")
  2. Make more API limitations configurable bitshares-core#1733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[0] Awaits Core Imp. Notification that this issue requies additional core functionality. [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [5c] Medium Indicates size of task. Est. between two and four hours [6] Core Impact flag identifying related to bitshares-core [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Development

No branches or pull requests

4 participants