Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize max_object_depth in appender config #83

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Conversation

abitmore
Copy link
Member

by setting a default value, for file_appender and gelf_appender.
For issue bitshares/bitshares-core#1392

by setting a default value, for file_appender and gelf_appender.
For issue bitshares/bitshares-core#1392
@jmjatlanta
Copy link

jmjatlanta commented Oct 19, 2018

Q: Do we need to do the same in console_appender.hpp?

Update: Nevermind. The constructor takes care of it.

@abitmore
Copy link
Member Author

I didn't add that to console appender because it has a default constructor which does the same.

Copy link

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants