Websocket code refactory and bugfix #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix duplicate code issue in websocket_client::connect() and websocket_client::secure_connect(), and other minor issues
Removes unnecessary differences between websocket_server_impl and websocket_tls_server_impl.
and replace an assertion with a check.
This may fix the issues that a websocket server may crash or hang when quitting
These functions were in websocket_server class but not in websocket_tls_server class: - get_listening_port - stop_listening - close
abitmore
added a commit
to bitshares/bitshares-core
that referenced
this pull request
Jun 20, 2020
abitmore
added a commit
to bitshares/bitshares-core
that referenced
this pull request
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issues:
Follow-up of #136 (comment).