Disable p2p network when delayed_node plugin is enabled #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable p2p network when delayed_node plugin is enabled
Resolved conflicts: - libraries/app/application.cpp - tests/common/database_fixture.cpp - tests/common/database_fixture.hpp - tests/elasticsearch/main.cpp
abitmore
force-pushed
the
no-p2p-for-delayed-node
branch
from
5341df7 to
00d8c7b
Compare
Since it's always called before destruction, it's good to just cleanup everything in the destructor.
Split it into several functions.
instead of a raw pointer. By the way, - move simulated_network from node.hpp and node.cpp to tests, - avoid referencing uint160_t, use message_hash_type or ripemd160.
and explicitly close chain database in destructor of application class
to try to avoid accessing freed memory when node is shutting down
to avoid accessing freed memory
and remove the unnecessary destructor from the plugin class
abitmore
force-pushed
the
no-p2p-for-delayed-node
branch
from
a72ea41 to
52ebad4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2040, for issue #104.
By the way refactored some code related to application, plugin framework and P2P networking, fixed some code smells.