Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign_memo command for signing with public keys #2386

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Conversation

abitmore
Copy link
Member

Fix sign_memo command for signing with public keys, and add CLI tests

  • more tests about read_memo and sign_memo
  • formatter of account_update_operation in account history
  • result formatter for SHA256 hashes in HTLC operations

- more tests about read_memo and sign_memo
- formatter of account_update_operation in account history
- result formatter for SHA256 hashes in HTLC operations
@abitmore abitmore added this to the 5.2.0 - Feature Release milestone Mar 21, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sschiessl-bcp
Copy link

What can we do with this (from user's viewpoint) that we could not do before?

@abitmore
Copy link
Member Author

@sschiessl-bcp the existing feature makes it possible that memo to be readable by a 3rd party but not the recipient, by using a key the 3rd party provided, although the use case is not obvious. Before the changes offered in this pull request, the user need to add the key to cli_wallet with a label, then run the command with that label. After the change, the user can run the command with the key directly.

@abitmore abitmore merged commit 89720b4 into develop Mar 22, 2021
@abitmore abitmore deleted the wallet-tests branch March 22, 2021 10:52
@sschiessl-bcp
Copy link

sschiessl-bcp commented Mar 22, 2021

Thx for clarification.

What would be an example use case? Auditing?

@abitmore
Copy link
Member Author

TBH I don't know. The feature is already there for a long time.
One use case I think is when the recipient doesn't have a valid memo key, the sender can still send the funds with a memo, and the memo is perhaps useful for the sender, e.g. for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants