BSIP87 Tests

[christophersanborn]

Unit tests followup to #2151.

[abitmore]

There are commits

• Improve error message in asset_claim_fees_evaluator
• Revert "Improve error message in asset_claim_fees_evaluator"

Please rebase and remove these commits from the history.

Thanks.

[abitmore]

OK, I changed my mind. The 2 commits are quite small, but it might need quite some efforts to remove them, I think it's fine to keep them, although generally it's not perfect.

[abitmore]

Ideally, we define a default value for this argument, then the function above with one argument fewer can be removed. Current code is acceptable for test cases though.

BTW I think it's better to add new parameters to the functions in database_fixture class, rather than adding new functions here. It's not a priority though, we can refactor in the future.

[MichelSantos]

Those are reasonable points. We'll defer the refactoring for now.

[MichelSantos]

Thanks for the helpful review @abitmore. Hopefully the revisions address all of your comments.

[christophersanborn]

@abitmore — I still have one open question here as to whether there is merit in rejecting an operation from do_evaluate() if force_settle_fee_parameter is unset in the operation but is set to a non-zero value in the asset object.

[abitmore]

Thanks.