Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release332 branch to release branch for SonarQube cache #2098

Merged
merged 2 commits into from
Feb 8, 2020

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Feb 7, 2020

See #2096.

The Travis build status and link for continuous-integration/travis-ci/pr showing in the PR is sometimes incorrect. The correct link for this PR is https://travis-ci.org/bitshares/bitshares-core/builds/647351439. It didn't pass. Retry after merged #2097.

@abitmore
Copy link
Member Author

abitmore commented Feb 8, 2020

The cache in master branch didn't help. Investigating.

@abitmore
Copy link
Member Author

abitmore commented Feb 8, 2020

There might be some issues or limitations with SonarQube CFamily cache, but the documentation is a bit poor. The feature is relatively new though. Only found a question here: https://community.sonarsource.com/t/cfamily-cache-limitations/19870, but no answer.

Steps I've tried:

  • built master branch and populated a cache;
  • created a new branch abitmore-travis-cache-test-master from master, the scanner reported 100% cache hit;
  • created a new branch abitmore-travis-cache-test from testnet, although lots of files are identical to master, the scanner reported no cache hit before being terminated in the middle.

Here are logs in Travis:

Still investigating.

@abitmore
Copy link
Member Author

abitmore commented Feb 8, 2020

No progress about the cache.

To get Travis work in release, testnet and master, I will port #2039 to release branch for next release.

@abitmore
Copy link
Member Author

abitmore commented Feb 8, 2020

All tests passed but SonarQube scanner didn't finish. Merging to benefit future pull requests.

@abitmore abitmore merged commit dd25caf into release Feb 8, 2020
@abitmore abitmore deleted the release332 branch July 6, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant