Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable p2p network when delayed_node plugin is enabled #2040

Merged

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Nov 3, 2019

Resolves #104

@pmconrad pmconrad added this to the 4.1.0 - Feature Release milestone Nov 3, 2019
abitmore
abitmore previously approved these changes Nov 3, 2019
@abitmore
Copy link
Member

abitmore commented Nov 3, 2019

Better cover network_broadcast_api as well.

@pmconrad
Copy link
Contributor Author

pmconrad commented Nov 4, 2019

network_broadcast_api methods already contain null-checks for p2p_node(). Question is if an error reply would be more appropriate than silently dropping the stuff to be broadcasted.
Also, broadcast_transaction_with_callback and broadcast_transaction_synchronous leak memory in this case because the callback is never executed. (The memory still gets free'd when the client closes the connection.)

@abitmore
Copy link
Member

abitmore commented Nov 4, 2019

Question is if an error reply would be more appropriate than silently dropping the stuff to be broadcasted.

I think raising an error is better.

@pmconrad
Copy link
Contributor Author

pmconrad commented Nov 6, 2019

Did some refactoring in database_fixture. This could also be a first step towards #1907 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants