-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional subscribe param to some database APIs #1868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
force-pushed
the
pr-1819-subscription
branch
from
July 25, 2019 13:36
2116906
to
d854564
Compare
Added test cases. This PR is now ready for review. |
These APIs are updated: - get_objects - get_assets - get_accounts - get_full_accounts - lookup_accounts - get_htlc
abitmore
force-pushed
the
pr-1819-subscription
branch
from
August 8, 2019 23:38
83e5f86
to
8d0e860
Compare
@sschiessl-bcp and @startailcoon: you may have interest. |
pmconrad
reviewed
Aug 13, 2019
abitmore
force-pushed
the
pr-1819-subscription
branch
from
August 13, 2019 20:45
272f69b
to
ebd5dbb
Compare
pmconrad
approved these changes
Aug 14, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1819.
These APIs are updated:
subscribe
parameter with typeoptional<bool>
( vector ids, optional<bool> subscribe )
( vector symbols_or_ids, optional<bool> subscribe )
( vector names_or_ids, optional<bool> subscribe )
( string lower_bound, int limit, optional<bool> subscribe )
( htlc_id id, optional<bool> subscribe )
subscribe
parameter tooptional<bool>
( vector names_or_ids, optional<bool> subscribe )