witness node accepts private key from file #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-ape
changed the title
abitmore
reviewed
Jun 20, 2019
|
Any insight why the key must be specified as a [public,private] pair? The public part is redundant, it would be simpler if the file contained only private keys. While you're at it, perhaps add another option that reads private keys from a file descriptor, as in https://www.gnupg.org/gph/en/manual/r1736.html . That would open the possibility to enter the key on startup, so that it doesn't have to be stored on disk. |
pmconrad
reviewed
Jun 21, 2019
crypto-ape
force-pushed
the
witness_node-accept_private_key_from_file
branch
from
3fb84da to
197acba
Compare
|
I guess most of the comments shall be resolved. Furthermore, I have rebased the changes on develop. The [public,private] is the original format. As far as the file descriptor goes, I am not that much interested in it right now. |
crypto-ape
force-pushed
the
witness_node-accept_private_key_from_file
branch
from
197acba to
35961a6
Compare
crypto-ape
force-pushed
the
witness_node-accept_private_key_from_file
branch
from
35961a6 to
390a43e
Compare
abitmore
reviewed
Aug 3, 2019
crypto-ape
force-pushed
the
witness_node-accept_private_key_from_file
branch
from
390a43e to
89e4e4e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Monkeys!
This change implements an option for adding private keys from files.
Ape out!