Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for node connectivity #1715

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Test for node connectivity #1715

wants to merge 6 commits into from

Conversation

jmjatlanta
Copy link
Contributor

@jmjatlanta jmjatlanta commented Apr 11, 2019

This test was built to test the p2p portion of node connectivity. I hope it to be of use for some tests.

This breaks out some of the graphene::app functionality to more easily get a test going that needs 2 nodes talking to each other.

@jmjatlanta jmjatlanta marked this pull request as ready for review May 16, 2019 15:26
@abitmore abitmore added this to the Future Feature Release milestone May 16, 2019
@pmconrad
Copy link
Contributor

In what way does this relate to the p2p_node_tests you added in #887 ?

@jmjatlanta
Copy link
Contributor Author

In what way does this relate to the p2p_node_tests you added in #887 ?

This PR is about creating a market and building some market history. #887 (and now #1764) add some access to the node to watch messages go through for address requests. Both contort node to get the information they need. They will no doubt cause conflicts, but I am unsure when (or if) they will get merged.

@pmconrad
Copy link
Contributor

This PR is about creating a market and building some market history.

I think you're confusing this with #1661. Otherwise you should rethink your commit messages. :-)

@jmjatlanta
Copy link
Contributor Author

I think you're confusing this with #1661. Otherwise you should rethink your commit messages. :-)

Is it obvious that I do not multitask well? That is the personal task list for improvement. Who knows what I was thinking when I wrote the above.

This ticket breaks things out into an "application_runner" for easier testing of 2 nodes. It has a lot in common with #1764 .

I will examine the two in order to see if anything in this ticket is worth salvaging.

@jmjatlanta
Copy link
Contributor Author

#1764 is believed to be near complete. Once that rolls, only a small piece of this branch is salvageable. I will close this ticket, but keep the branch around until I can redo it to only keep the good parts (big block and big transaction tests).

@jmjatlanta jmjatlanta closed this Aug 26, 2019
@abitmore abitmore reopened this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants