Add a test case for market_history plugin #1661
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
commented
Mar 18, 2019
tests/tests/history_api_tests.cpp
Outdated
| op.issuer = committee_account; | ||
| op.new_feed_producers = { committee_account, alice.id, bob.id }; | ||
| trx.operations.push_back( op ); | ||
| sign( trx, private_key ); |
There was a problem hiding this comment.
For better performance (here and other code in this PR), no need to sign the transactions.
There was a problem hiding this comment.
Signing removed. Test now takes ~23 secs to run on my machine.
17 tasks
abitmore
commented
Sep 13, 2019
| // a function to transmit a transaction | ||
| auto transmit_tx = [this, alice, bob, alice_private_key, bob_private_key](const simple_tx& tx) { | ||
| const auto seller_private_key = ( tx.from.id == alice.id ? alice_private_key : bob_private_key ); | ||
| const auto buyer_private_key = ( tx.from.id == alice.id ? bob_private_key : alice_private_key ); |
There was a problem hiding this comment.
These variables can be removed.
| PUSH_TX( db, trx, ~0 ); | ||
| generate_block(); | ||
| trx.clear(); | ||
| publish_feed( committee_account, asset_id_type(), 2, usd.id, 1, asset_id_type() ); |
There was a problem hiding this comment.
After generated a block, the usd object would become unusable. The same for following code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @jmjatlanta for working on #1277 and #1627. The test case is useful, IMHO it should be merged after fixed performance issues.