Fix #782: Change hard-coded limitations in API's to configurable #1513

manikey123 · 2019-01-04T02:22:02Z

Added the review comments in request #1478 and test case for the api validation

This is wrt issue #782
Part A (Completed): get_account_history_operations -made FC_ASSERT limit configurable
and wrote the testcase for the same

Testcase Scenarios (Completed for PartA) :

created 1 account with higher return limits(200)
created 2 account with higher return limits(200)
No asset_create op larger than id1 with higher return limits(200)
Limited 1 returns 1 result
alice has 1 op returns 1 result
create a bunch of accounts and return set the limit to 125 and the max operation size to higher return limits(125)-- operation is limited by the max-operation-limit tickets:
get_account_history_operations fails with partial_history and stop at 0 #1490

Part B: get_account_history - Do you want me to proceed with Part2 for get_account_history to make its FC_ASSSERT configurable?
Test cases already present

get_account_history

Part C: Below apis have FC_ASSERT should they be made configurable?
Currently test cases not present. If they need to be implemented would need to know the scenarios

get_grouped_limit_orders
get_asset_holders_count
get_asset_holders
get_account_history_by_operations
get_relative_account_history
get_fill_order_history

updates on 12/20

Develop

tests/common/database_fixture.cpp

tests/tests/history_api_tests.cpp

pmconrad · 2019-01-07T14:48:04Z

Feel free to continue with B and C.
IMO writing a full-blown test case for the other API calls is beyond the scope of #782. Would be good to check that the configured limit value works in each case though (in the sense that calling the API with a value below the configured limit returns something, possibly an empty result, and that calling it with a value above the limit throws as expected).

updated based on comments

update the file for merge issue

updated int value

manikey123 · 2019-01-09T19:41:30Z

Can part A which I completed be merged with the master code
For parts B and C I can make a new PR. ?
@pmconrad @jmjatlanta

pmconrad · 2019-01-10T14:16:50Z

Code-wise I'd say this can be merged on its own, however, I would like to see a consistent naming scheme for the option names here and in the future PRs. For example, api-limit-<name_of_api_call>. IMO the general purpose of this option becomes clear immediately if you read only the first one or two components of the name.

manikey123 · 2019-01-13T21:39:50Z

Added all the remaining parts for the below apis. Plz review
get_account_history
get_account_history_operations
get_grouped_limit_orders
get_relative_account_history
get_account_history_by_operations
get_asset_holders

libraries/app/include/graphene/app/api.hpp

tests/tests/history_api_tests.cpp

pmconrad · 2019-01-14T12:59:21Z

Hint: use rebase -i and a force-push to get rid of the accidentally added file.

tests/tests/group_order_api_tests.cpp

tests/tests/history_api_tests.cpp

pmconrad · 2019-01-14T13:12:48Z

One testcase is failing in travis. Can't immediately see what's wrong, please check and fix.

Adding all the changes from the develop branch

pmconrad · 2019-02-25T14:09:36Z

Argh, you've destroyed the commit history!
Please check if you still have 906beb3 in your repo, then base the whitespace changes on top of that.

manikey123 · 2019-03-03T22:48:44Z

Please check if you still have 906beb3 in your repo, then base the whitespace changes on top of that.
whatever commit history I could find from my local repo I have commit that. and then committed the required changes over it plz do review

pmconrad · 2019-03-06T15:17:52Z

libraries/app/api.cpp

    asset_api::~asset_api() { }

-    vector<account_asset_balance> asset_api::get_asset_holders( asset_id_type asset_id, uint32_t start, uint32_t limit ) const {
-
+    vector<account_asset_balance> asset_api::get_asset_holders( std::string asset, uint32_t start, uint32_t limit ) const {


This change is already in develop branch. #1272

it was added after I made the updates for the PR. had to merge the changes for the develop branch

This should be handled during the merge, not in advance.

@pmconrad IIRC there was a conflict, fixed by merging develop branch into this branch. IMHO it's the correct approach. Actually, if you check the whole PR diff or the "condensed" merge commit but not the full merge commit, you won't see this change.

Merge conflicts should be fixed during the merge.

In this case, some code was c&p'ed from develop, maybe in order to avoid a merge conflict. That's the wrong approach.

I know the accidentally added / removed code doesn't show up in the full PR diff, but I'd like to have a clean and lean history. That's why git rebase -i exists.

tests/tests/history_api_tests.cpp

pmconrad

Thanks for restoring history. c0a1109 is what I originally approved I believe.

I'm confused by your later commits though. Why do you add tests only to remove them again? If that was an accident, please squash the two commits into one and force-push.

There's an unrelated API change in there, probably also by accident.

pmconrad · 2019-03-18T13:12:52Z

Thanks. Squashed one too many but that doesn't hurt. ba3a895 is the parent of the abovementioned c0a1109, and a4108e0 include the changes from that.
Now please merge develop and resolve the conflicts.

updated for test case to match the input type of the api after merge with develop branch

pmconrad

Looks good now. Thanks for your patience. :-)

@abitmore ?

abitmore · 2019-03-19T20:48:07Z

Personally I don't like some coding styles appeared in the code: tabs, long lines (>118 characters), inconsistent indentations/padding/spacing E.G. sometimes no white spaces around = or after ,, trailing white spaces(old code), and etc. The code itself looks fine (I didn't thoroughly check).

pmconrad · 2019-03-20T13:42:05Z

To be fair, the diff shows some very long lines in the unchanged parts as well.
I expect the complete codebase will be reformatted in the context of #1318 anyway, so I don't think it will pay off now.

manikey123 added 3 commits December 20, 2018 09:02

Merge pull request #1 from bitshares/develop

cb5250f

updates on 12/20

Merge pull request #2 from bitshares/develop

a4afb7c

Develop

added test case for 782 part1

a22e850

This was referenced Jan 4, 2019

782 part1 #1478

Closed

Change hard-coded limitations in API's to configurable #782

Closed

pmconrad reviewed Jan 7, 2019

View reviewed changes

tests/common/database_fixture.cpp Outdated Show resolved Hide resolved

pmconrad reviewed Jan 7, 2019

View reviewed changes

tests/tests/history_api_tests.cpp Outdated Show resolved Hide resolved

pmconrad reviewed Jan 7, 2019

View reviewed changes

tests/tests/history_api_tests.cpp Show resolved Hide resolved

jmjatlanta mentioned this pull request Jan 7, 2019

get_key_references performance issue? #1472

Closed

19 tasks

manikey123 added 6 commits January 8, 2019 01:18

Update history_api_tests.cpp

b4195aa

updated based on comments

updated based on review comment received

1829a9a

updated based on review comment received1

d66f15b

Update history_api_tests.cpp

ab7b44a

update the file for merge issue

Update application.cpp

c3db2db

updated int value

updating uint64_t

43a743b

manikey123 added 2 commits January 13, 2019 13:31

782 pt 1 and 2

9a9a8f8

782 pt 1 and 2 edit

3aecf1f

pmconrad reviewed Jan 14, 2019

View reviewed changes

libraries/app/include/graphene/app/api.hpp Outdated Show resolved Hide resolved

pmconrad reviewed Jan 14, 2019

View reviewed changes

tests/tests/history_api_tests.cpp Show resolved Hide resolved

pmconrad reviewed Jan 14, 2019

View reviewed changes

tests/tests/group_order_api_tests.cpp Outdated Show resolved Hide resolved

pmconrad reviewed Jan 14, 2019

View reviewed changes

tests/tests/history_api_tests.cpp Outdated Show resolved Hide resolved

manikey123 added 3 commits January 14, 2019 16:45

Merge pull request #3 from bitshares/develop

a724f9d

Adding all the changes from the develop branch

782 chnages based on review comments

3066629

782 changes based on travis build and review comments

9d6b06f

abitmore modified the milestones: Future Feature Release, Possible 201904 Feature Release Feb 20, 2019

manikey123 dismissed pmconrad’s stale review via 05d13ed February 24, 2019 03:29

manikey123 force-pushed the 782_test_p1 branch 2 times, most recently from 05d13ed to a324a18 Compare February 25, 2019 07:53

manikey123 force-pushed the 782_test_p1 branch 3 times, most recently from 74406e9 to 0d3a779 Compare March 3, 2019 22:31

pmconrad reviewed Mar 6, 2019

View reviewed changes

tests/tests/history_api_tests.cpp Outdated Show resolved Hide resolved

pmconrad suggested changes Mar 6, 2019

View reviewed changes

Update as per the review comments 1513

a4108e0

manikey123 force-pushed the 782_test_p1 branch from adc0086 to a4108e0 Compare March 17, 2019 20:41

manikey123 added 3 commits March 18, 2019 16:34

Merge branch 'develop' into 782_test_p1

3014c38

Update asset_api_tests.cpp

df514ac

updated for test case to match the input type of the api after merge with develop branch

updated api.cpp for build failures

78cb2c7

pmconrad approved these changes Mar 19, 2019

View reviewed changes

pmconrad merged commit ae78c2d into bitshares:develop Mar 20, 2019

pmconrad mentioned this pull request Apr 29, 2019

add htlc api calls #1729

Closed

MichelSantos mentioned this pull request May 1, 2019

Release Notes: BitShares Core 3.1.0 #1745

Closed

oxarbitrage mentioned this pull request May 6, 2019

get_full_account only contains given withdrawal_permissions #1654

Closed

manikey123 mentioned this pull request Aug 12, 2019

BTS PR 1733: Make more API limitations configurable #1903

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #782: Change hard-coded limitations in API's to configurable #1513

Fix #782: Change hard-coded limitations in API's to configurable #1513

manikey123 commented Jan 4, 2019 •

edited

Loading

pmconrad commented Jan 7, 2019

manikey123 commented Jan 9, 2019

pmconrad commented Jan 10, 2019

manikey123 commented Jan 13, 2019

pmconrad commented Jan 14, 2019

pmconrad commented Jan 14, 2019

pmconrad commented Feb 25, 2019

manikey123 commented Mar 3, 2019

pmconrad Mar 6, 2019

abitmore Mar 6, 2019

manikey123 Mar 7, 2019 •

edited

Loading

pmconrad Mar 7, 2019

abitmore Mar 8, 2019

pmconrad Mar 10, 2019

pmconrad left a comment

pmconrad commented Mar 18, 2019

pmconrad left a comment

abitmore commented Mar 19, 2019

pmconrad commented Mar 20, 2019

Fix #782: Change hard-coded limitations in API's to configurable #1513

Fix #782: Change hard-coded limitations in API's to configurable #1513

Conversation

manikey123 commented Jan 4, 2019 • edited Loading

pmconrad commented Jan 7, 2019

manikey123 commented Jan 9, 2019

pmconrad commented Jan 10, 2019

manikey123 commented Jan 13, 2019

pmconrad commented Jan 14, 2019

pmconrad commented Jan 14, 2019

pmconrad commented Feb 25, 2019

manikey123 commented Mar 3, 2019

pmconrad Mar 6, 2019

Choose a reason for hiding this comment

abitmore Mar 6, 2019

Choose a reason for hiding this comment

manikey123 Mar 7, 2019 • edited Loading

Choose a reason for hiding this comment

pmconrad Mar 7, 2019

Choose a reason for hiding this comment

abitmore Mar 8, 2019

Choose a reason for hiding this comment

pmconrad Mar 10, 2019

Choose a reason for hiding this comment

pmconrad left a comment

Choose a reason for hiding this comment

pmconrad commented Mar 18, 2019

pmconrad left a comment

Choose a reason for hiding this comment

abitmore commented Mar 19, 2019

pmconrad commented Mar 20, 2019

manikey123 commented Jan 4, 2019 •

edited

Loading

manikey123 Mar 7, 2019 •

edited

Loading