Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for errors while loading object_database #1461

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Fix for errors while loading object_database #1461

merged 2 commits into from
Dec 4, 2018

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Dec 3, 2018

Errors while reading object_database were silently ignored, which could lead to an incomplete or inconsistent database after restart. Now, exceptions are no longer caught and will trigger application abort.

Also includes a fix for a minor efficiency in an API call.

@oxarbitrage
Copy link
Member

I was not able to make the travis build pass so i am building it manually ... will update in a bit.

oxarbitrage
oxarbitrage approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, all tests passing. thanks.

@pmconrad pmconrad merged commit 91eb971 into develop Dec 4, 2018
@pmconrad pmconrad deleted the fixes branch December 4, 2018 16:39
@pmconrad pmconrad added 3d Bug Classification indicating the existing implementation does not match the intention of the design 4a Low Priority Priority indicating minimal impact to system/user -OR- an inexpensive workaround exists 9a Tiny Effort estimation indicating TBD labels Dec 4, 2018
@pmconrad pmconrad added this to the 201812 - Feature Release milestone Dec 4, 2018
@MichelSantos MichelSantos mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4a Low Priority Priority indicating minimal impact to system/user -OR- an inexpensive workaround exists 9a Tiny Effort estimation indicating TBD
Projects
None yet
Milestone
201902 - Feature Release
Development

Successfully merging this pull request may close these issues.
3 participants
@pmconrad @oxarbitrage @abitmore