Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change comment #1349

Merged
merged 2 commits into from
Sep 29, 2018
Merged

change comment #1349

merged 2 commits into from
Sep 29, 2018

Conversation

oxarbitrage
Copy link
Member

@oxarbitrage oxarbitrage mentioned this pull request Sep 28, 2018
Closed
pmconrad
pmconrad reviewed Sep 29, 2018
View reviewed changes
libraries/chain/db_update.cpp Outdated
@@ -116,9 +116,10 @@ void database::update_last_irreversible_block()

static_assert( GRAPHENE_IRREVERSIBLE_THRESHOLD > 0, "irreversible threshold must be nonzero" );

// 1 1 1 2 2 2 2 2 2 2 -> 2 .7*10 = 7
// 1 1 1 2 2 2 2 2 2 2 -> 1 .3*10 = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result "2" was correct - offset is 0-based, so it's the 4th element.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed, thanks.

@oxarbitrage oxarbitrage added this to the 201810 - Feature Release milestone Sep 29, 2018
pmconrad
pmconrad approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmconrad pmconrad merged commit 30f93cf into develop Sep 29, 2018
@TheTaconator TheTaconator mentioned this pull request Oct 16, 2018
Closed
@abitmore abitmore deleted the oxarbitrage-patch-1 branch October 20, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201810 - Feature Release
Development

Successfully merging this pull request may close these issues.
2 participants
@oxarbitrage @pmconrad