Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused variable _consecutive_production_enabled #1294

Merged
merged 3 commits into from
Aug 29, 2018
Merged

remove unused variable _consecutive_production_enabled #1294

merged 3 commits into from
Aug 29, 2018

Conversation

secp256
Copy link

@secp256 secp256 commented Aug 28, 2018

No description provided.

abitmore
abitmore previously approved these changes Aug 28, 2018
@abitmore
Copy link
Member

Note: related startup option was removed in this commit: 26007bb

oxarbitrage
oxarbitrage previously approved these changes Aug 28, 2018
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zhuliting for the work and @abitmore for adding the commit where the code for the option was removed.

@abitmore
Copy link
Member

Perhaps we can remove these as well:

case block_production_condition::consecutive:
elog("Not producing block because the last block was generated by the same witness.\nThis node is probably disconnected from the network so block production has been disabled.\nDisable this check with --allow-consecutive option.");
break;

@secp256 secp256 dismissed stale reviews from oxarbitrage and abitmore via ff1fa3f August 29, 2018 03:04
@abitmore abitmore merged commit 5b8192c into bitshares:develop Aug 29, 2018
@abitmore abitmore added this to the 201810 - Feature Release milestone Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants