clean old style codes #1250
clean old style codes #1250
Conversation
| @@ -66,7 +66,7 @@ namespace graphene { namespace db { | |||
| catch ( const fc::exception& e ) | |||
| { | |||
| elog( "${e}", ("e",e.to_detail_string() ) ); | |||
| throw; // maybe crash.. | |||
| //throw; // maybe crash.. | |||
| } | |||
There was a problem hiding this comment.
i am not very sure if we can just remove the throw here or replace it with FC_THROW with message and remove elog.
There was a problem hiding this comment.
As the comment indicates, the program crash at this point is deliberate. The problem is that the internal database may be in an inconsistent state at this point (i. e. the current session was only partially undone). The node cannot reliably continue to operate, so commenting this out is definitely wrong.
There was a problem hiding this comment.
So, the node should exit immediately, but why not just use std::exit?
There was a problem hiding this comment.
there is a (slight) chance that this throw does not actually end the program, and it has to do with stack unwinding. I believe that is why the comment reads "maybe crash..."
See https://akrzemi1.wordpress.com/2011/09/21/destructors-that-throw/
More thought should be put into what should happen in this case.
There was a problem hiding this comment.
anything commented "Maybe crash..." is something worth looking into imho :D
There was a problem hiding this comment.
I know GCC 7.3.0 gives a warning about throw within a destructor. That's the main reason I created issue #1246
There was a problem hiding this comment.
Hm, according to the article referenced above, the destructor is implicitly declared as noexcept, and should therefore always terminate the program when it throws.
Termination is what we want here, because the database is inconsistent and we cannot repair it.
There was a problem hiding this comment.
The GCC 8 says throw in destructor will terminate the program, and that is now what we wanted, but why not exit the program in a normal way instead of throwing an exception implicitly? can we replace the throw with std::exit()?
There was a problem hiding this comment.
we cannot exit, terminate in libraries, in libraries we can only return or throw
There was a problem hiding this comment.
look please #1050 why we cannot exit or terminate in libraries
As no agreement is reached, undo the modifying
Stay unchanged for agreement
|
@cwyyprog Thank you for the contributions to BitShares development. I hope to connect with you directly about the Thank you. |
fix annoying warnings when compile with gcc 8