Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document differences among boost versions #881

Closed
abitmore opened this issue Apr 26, 2018 · 8 comments
Closed

Document differences among boost versions #881

abitmore opened this issue Apr 26, 2018 · 8 comments

Comments

@abitmore
Copy link
Member

abitmore commented Apr 26, 2018

Things that I'm aware of:

  • if built with boost 1.60 (and perhaps other versions), some parameter styles in command line is not supported. E.G.
    • ./cli_wallet -s ws://1.2.3.4:5678/ works with boost 1.57 and 1.58, but doesn't work with 1.60
    • ./cli_wallet -sws://1.2.3.4:5678/ works with boost 1.57, 1.58 and 1.60
  • time_point_sec jsonifies to different result in boost 1.64, as mentioned in fc::time_point_sec::to_iso_string is broken #597

Note: this document is for users of witness_node and cli_wallet, not for the core developers.

@jmjatlanta
Copy link
Contributor

Perhaps the stacktrace on segfault should be mentioned as not happening for boost versions prior to 1.65.

@cedar-book
Copy link

cedar-book commented May 9, 2018

If we create the information page something like this (--) somewhere, would it be meaningful?
--> Correct link https://dev.bitshares.works/en/master/development/installation/boost_versions.html (2019-2-26)

@abitmore
Copy link
Member Author

abitmore commented May 9, 2018

@cedar-book yes. Thanks!

@cedar-book
Copy link

cedar-book commented May 30, 2018

@ryanRfox, The boost versions information page for Ubuntu, OS X -- updated (2019-2-26)

@cedar-book
Copy link

cedar-book commented Jul 24, 2018

also have this information page Boost Versions -- updated (2019-2-26)

@jmjatlanta
Copy link
Contributor

Boost 1.66 multi_index handles exceptions differently than earlier versions. See #852

@abitmore
Copy link
Member Author

@jmjatlanta this document if for users of witness_node/cli_wallet, but not the developers. Since we don't support 1.66 right now, IMHO no need to document it. Once we fixed #852, still no need to document it because users won't notice the difference.

@ryanRfox
Copy link
Contributor

Closing because #852 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants