-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fail reason to proposal object #730
Comments
Just a note: @xeroc is working on this. |
The problem with this ticket is that proposals are only in the database as long as they are not expired or executed. That lead us to implement a plugin for persistent proposals (for PeerPlays specifically). This plugin is currently extended to also handle exceptions. |
@xeroc persistent proposal is another topic which is out of scope of this issue. In this issue we'll focus on active proposals but not expired ones. OP is clear: add a new field in proposal_object to indicate why a proposal had failed to execute. If you're going this way, please proceed; otherwise please unassign yourself or leave a message so others will know to work on it. |
I have unassigned myself. |
@jmjatlanta I believe that because this is merged it should be marked Closed as well. I'll allow you to do that when appropriate. Thank you for moving to Done. In the future, you may automate this: https://blog.github.com/2013-05-14-closing-issues-via-pull-requests/ |
Learn something new every day. Thanks! |
For better UX, we can add a new field in
proposal_object
to indicate why a proposal had failed to execute.The text was updated successfully, but these errors were encountered: