-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: support modern c++ compilers #618
Comments
Welcome. Can start a new branch or project for it. Just lack of resources so far. |
Where does it force use of an old compiler? I regularly build with gcc-5. CMakeLists.txt says at least 4.8. |
@pmconrad yes you can use a newer version but you are limited of the features you can use as they also must be supported by gcc 4.8, for instance if you want to use features such as |
It makes sense to revise the c++ standard we're building on. Shouldn't tie it to a compiler version though. |
Alright thanks for the answer, I closed the ticket (by mistake) as I won't work right away on it |
Compiler made great progress in the past few years but you are forcing yourself to use old version of compiler (e.g. 4.8)
I understand you are forced to use a subset to c++ due to the cross platform compatibility but once in a while forcing all the users to also update their compiler will only improve the overall performance of this library, also by using more recent compiler, you will be able to use more recent feature such as C++17, the recent ABI with sso, and so on
Also as you are targeting performance, why are you not using optimization flag for your release build?
Using at least O2 and having more agressive inlining in the critical path will greatly help the latency
That request might comes as too broad but I will be interested to know your plan to upgrade that part, as it's an important one performance wise
If pull request are welcome on that area I would gladly help
The text was updated successfully, but these errors were encountered: