Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support modern c++ compilers #618

Closed
Dllieu opened this issue Feb 1, 2018 · 5 comments
Closed

feature request: support modern c++ compilers #618

Dllieu opened this issue Feb 1, 2018 · 5 comments

Comments

@Dllieu
Copy link

Dllieu commented Feb 1, 2018

Compiler made great progress in the past few years but you are forcing yourself to use old version of compiler (e.g. 4.8)

I understand you are forced to use a subset to c++ due to the cross platform compatibility but once in a while forcing all the users to also update their compiler will only improve the overall performance of this library, also by using more recent compiler, you will be able to use more recent feature such as C++17, the recent ABI with sso, and so on

Also as you are targeting performance, why are you not using optimization flag for your release build?
Using at least O2 and having more agressive inlining in the critical path will greatly help the latency

That request might comes as too broad but I will be interested to know your plan to upgrade that part, as it's an important one performance wise
If pull request are welcome on that area I would gladly help

@Dllieu Dllieu changed the title feature request: support modern c++ tools feature request: support modern c++ compilers Feb 1, 2018
@abitmore
Copy link
Member

abitmore commented Feb 2, 2018

Welcome. Can start a new branch or project for it. Just lack of resources so far.

@pmconrad
Copy link
Contributor

pmconrad commented Feb 2, 2018

Where does it force use of an old compiler? I regularly build with gcc-5. CMakeLists.txt says at least 4.8.

@Dllieu Dllieu closed this as completed Feb 2, 2018
@Dllieu
Copy link
Author

Dllieu commented Feb 2, 2018

@pmconrad yes you can use a newer version but you are limited of the features you can use as they also must be supported by gcc 4.8, for instance if you want to use features such as if constexpr from gcc 6+ well it won't be compatible with the current requirement

@pmconrad
Copy link
Contributor

pmconrad commented Feb 3, 2018

It makes sense to revise the c++ standard we're building on. Shouldn't tie it to a compiler version though.
And yes, we need to stay compatible with distros that are a couple of years old. Requiring C++17 (for example) would be premature IMO.

@Dllieu
Copy link
Author

Dllieu commented Feb 4, 2018

Alright thanks for the answer, I closed the ticket (by mistake) as I won't work right away on it

@abitmore abitmore mentioned this issue Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants