Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brain key compatibility between bitshares-core and bitshares-ui #2354

Closed
3 of 17 tasks
abitmore opened this issue Feb 12, 2021 · 1 comment · Fixed by #2355
Closed
3 of 17 tasks

Brain key compatibility between bitshares-core and bitshares-ui #2354

abitmore opened this issue Feb 12, 2021 · 1 comment · Fixed by #2355
Milestone
5.2.0 - Feature R...

Comments

@abitmore
Copy link
Member

Bug Description

Brain keys generated in bitshares-ui (all lower-case letters) can not be used in cli_wallet with command derive_owner_keys_from_brain_key to derive the same key pairs, because cli_wallet always normalize the brain keys by converting all letters to upper case.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added this to the 5.2.0 - Feature Release milestone Feb 12, 2021
@abitmore abitmore mentioned this issue Feb 12, 2021
Merged
@abitmore abitmore linked a pull request Feb 13, 2021 that will close this issue
Skip normalizing brain key when deriving keys #2355
Merged
@abitmore
Copy link
Member Author

Fixed by #2355.

@abitmore abitmore mentioned this issue Apr 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0 - Feature Release
Development

Successfully merging a pull request may close this issue.

Skip normalizing brain key when deriving keys bitshares/bitshares-core
1 participant
@abitmore