Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional auto-subscription parameters to APIs #1819

Closed
1 of 8 tasks
abitmore opened this issue Jun 21, 2019 · 1 comment
Closed
1 of 8 tasks

Add optional auto-subscription parameters to APIs #1819

abitmore opened this issue Jun 21, 2019 · 1 comment
Assignees

Comments

@abitmore
Copy link
Member

User Story
These APIs may auto-subscribe to querying objects:

  • get_accounts(vector)
  • get_assets(vector)
  • get_objects(vector)
  • lookup_accounts(string, uint32_t)

The BitShares UI team wants to be able to opt-out auto-subscription for all these APIs, just like the behavior of get_full_accounts API (bitshares/bitshares-ui#2612).

Since bitshares-core now supports optional parameters for API calls (bitshares/bitshares-fc#126), the feature can be implemented by adding an optional parameter to the APIs without break existing client applications.

Originally discussed in #777. Part of #1766.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • UX (the User Experience)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@oxarbitrage
Copy link
Member

Closed by #1868

Documentation may be needed somewhere but not mandatory as commands involved will keep working as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants