Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BitShares Core uses Boost::Signal, which is deprecated #1512

Closed
3 tasks
jmjatlanta opened this issue Jan 2, 2019 · 2 comments
Closed
3 tasks

BitShares Core uses Boost::Signal, which is deprecated #1512

jmjatlanta opened this issue Jan 2, 2019 · 2 comments
Assignees
@jmjatlanta
Milestone
201902 - Feature ...

Comments

@jmjatlanta
Copy link
Contributor

Running CMake on BitShares causes an error due to Boost no longer shipping with Boost::Signal. This has been deprecated for a while, and replaced with Boost::Signal2. This issue is to research and determine the impact of upgrading to Boost::Signal2

Attempted with Boost 1.70 and Boost 1.69.

Build Environment
Details about the build environment, including the relevant required libraries. Much of this information can be found in the CMakeFiles/CMakeOutput.log.

  • Host OS: Ubuntu 18.10
  • Host Physical RAM 32GB
  • Source Branch/Tag: develop
  • OpenSSL Version: 1.1.0
  • Boost Version: 1.70
  • C++ Compiler: gcc

Steps To Reproduce
cmake

CORE TEAM TASK LIST

  • Evaluate Build Error
  • Provide build guidance
  • Create Bug Report
@jmjatlanta jmjatlanta changed the title BitShares Core uses Boost::Signal which is deprecated BitShares Core uses Boost::Signal, which is deprecated Jan 2, 2019
@jmjatlanta
Copy link
Contributor Author

From what I have seen so far, BitShares-fc and BitShares-core do not use signals, but instead use signals2 already. The only reference is in the CMakeFiles.txt. Evidently this is a left-over from previous use. I have removed those references, and am testing.

@jmjatlanta jmjatlanta self-assigned this Jan 4, 2019
This was referenced Jan 4, 2019
Merged
Merged
@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 5, 2019
@jmjatlanta
Copy link
Contributor Author

Fixed by pull 1514 and fc pull 101

@MichelSantos MichelSantos mentioned this issue Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmjatlanta jmjatlanta

Labels
None yet
Projects
None yet
Milestone
201902 - Feature Release
Development

No branches or pull requests
2 participants
@jmjatlanta @abitmore