Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli_wallet crashes when doing import_key on Mac #1244

Closed
ghost opened this issue Aug 10, 2018 · 3 comments
Closed

cli_wallet crashes when doing import_key on Mac #1244

ghost opened this issue Aug 10, 2018 · 3 comments
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2e Ready for Testing Status indicating the solution is sufficiently developed to begin testing 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 CLI Impact flag identifying the command line interface (CLI) wallet application
Milestone
201810 - Feature ...

Comments

@ghost
Copy link

ghost commented Aug 10, 2018

Encountered Segmentation fault when performing import_key in cli_wallet as below:
screen shot 2018-08-10 at 8 36 37 am

The root cause is due to C++ compiler "intelligently" removed the null pointer check inside boost library, when calling the boost::filesystem::copy function without passing a placeholder of error_code.
@abitmore
Copy link
Member

Just FYI, your contribution has been added in this PR: bitshares/bitshares-fc#73.

@ghost
Copy link
Author

ghost commented Aug 10, 2018

Thanks abit

@ryanRfox ryanRfox added 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2e Ready for Testing Status indicating the solution is sufficiently developed to begin testing 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 CLI Impact flag identifying the command line interface (CLI) wallet application labels Aug 10, 2018
@pmconrad pmconrad mentioned this issue Aug 17, 2018
Merged
@abitmore
Copy link
Member

Fixed by #1248.

@TheTaconator TheTaconator mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 2e Ready for Testing Status indicating the solution is sufficiently developed to begin testing 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 CLI Impact flag identifying the command line interface (CLI) wallet application
Projects
None yet
Milestone
201810 - Feature Release
Development

No branches or pull requests
2 participants
@abitmore @ryanRfox