-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/spring-cloud-dataflow] Bump JDK versions for Spring Cloud Dataflow images #24449
Comments
Thank you so much for the insight! I will forward this to the engineering team |
SCDF Server was upgraded to JDK 17: Thank you! Now only the Prometheus Rsocket Proxy is missing. @javsalgar would you accept a PR for this change if I send one? |
Hi, |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary. |
Affected images:
What steps will reproduce the bug?
bitnami/spring-cloud-dataflow:2.10.0-debian-11-r14
and/orbitnami/prometheus-rsocket-proxy:1.5.0-debian-11-r61
with CPU and memory limits.What is the expected behavior?
The containers should respect the Kubernetes resource limits
What do you see instead?
The containers use more than the allotted memory and are OOMKilled.
Additional information
The SCDF image
https://github.com/bitnami/containers/blob/main/bitnami/spring-cloud-dataflow/2/debian-11/Dockerfile#L26
and the Prometheus Rsocket Proxy image
https://github.com/bitnami/containers/blob/main/bitnami/prometheus-rsocket-proxy/1/debian-11/Dockerfile#L25
both use JDK 8.
In the most recent upgrade of Kubernetes 1.25, cgroups v2 has been activated by default.
https://kubernetes.io/docs/concepts/architecture/cgroups/#cgroup-v2
However, there's an issue in which JDK 8 does NOT respect the resource limits which k8s imposes using cgroups v2.
As a result, the containers push past their allotted CPU and memory and get constantly getting OOMKilled.
See: https://blog.kintone.io/entry/2022/03/08/170206
and Azure/AKS#3443
Due to this, we'd like to request upgrading the JDK version used in these images, ideally to JDK 17 as it's the only LTS version that natively understands cgroups v2.
https://endoflife.date/java
I've run some tests by rebuilding these images using JDK 15 and can confirm that the issues do not occur there.
The text was updated successfully, but these errors were encountered: