Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/spring-cloud-dataflow] Bump JDK versions for Spring Cloud Dataflow images #24449

Closed
OmegaVVeapon opened this issue Feb 17, 2023 · 5 comments
Assignees
Labels
solved spring-cloud-dataflow stale 15 days without activity tech-issues The user has a technical issue about an application

Comments

@OmegaVVeapon
Copy link

OmegaVVeapon commented Feb 17, 2023

Affected images:

  • bitnami/spring-cloud-dataflow:2.10.0-debian-11-r14
  • bitnami/prometheus-rsocket-proxy:1.5.0-debian-11-r61

What steps will reproduce the bug?

  1. Deploy a pod using Kubernetes 1.25 with bitnami/spring-cloud-dataflow:2.10.0-debian-11-r14 and/or bitnami/prometheus-rsocket-proxy:1.5.0-debian-11-r61 with CPU and memory limits.

What is the expected behavior?

The containers should respect the Kubernetes resource limits

What do you see instead?

The containers use more than the allotted memory and are OOMKilled.

Additional information

The SCDF image
https://github.com/bitnami/containers/blob/main/bitnami/spring-cloud-dataflow/2/debian-11/Dockerfile#L26

and the Prometheus Rsocket Proxy image
https://github.com/bitnami/containers/blob/main/bitnami/prometheus-rsocket-proxy/1/debian-11/Dockerfile#L25

both use JDK 8.

In the most recent upgrade of Kubernetes 1.25, cgroups v2 has been activated by default.
https://kubernetes.io/docs/concepts/architecture/cgroups/#cgroup-v2

However, there's an issue in which JDK 8 does NOT respect the resource limits which k8s imposes using cgroups v2.
As a result, the containers push past their allotted CPU and memory and get constantly getting OOMKilled.

See: https://blog.kintone.io/entry/2022/03/08/170206
and Azure/AKS#3443

Due to this, we'd like to request upgrading the JDK version used in these images, ideally to JDK 17 as it's the only LTS version that natively understands cgroups v2.
https://endoflife.date/java

I've run some tests by rebuilding these images using JDK 15 and can confirm that the issues do not occur there.

@OmegaVVeapon OmegaVVeapon added the tech-issues The user has a technical issue about an application label Feb 17, 2023
@github-actions github-actions bot added the triage Triage is needed label Feb 17, 2023
@javsalgar javsalgar changed the title Bump JDK versions for Spring Cloud Dataflow images [bitnami/spring-cloud-dataflow] Bump JDK versions for Spring Cloud Dataflow images Feb 21, 2023
@javsalgar
Copy link
Contributor

Thank you so much for the insight! I will forward this to the engineering team

@github-actions github-actions bot added on-hold Issues or Pull Requests with this label will never be considered stale and removed triage Triage is needed labels Feb 21, 2023
@OmegaVVeapon
Copy link
Author

SCDF Server was upgraded to JDK 17:
https://github.com/bitnami/containers/blob/main/bitnami/spring-cloud-dataflow/2/debian-11/Dockerfile#L26
and it fixed the cgroups v2 issue as expected.

Thank you!

Now only the Prometheus Rsocket Proxy is missing.
https://github.com/bitnami/containers/blob/main/bitnami/prometheus-rsocket-proxy/1/debian-11/Dockerfile#L25

@javsalgar would you accept a PR for this change if I send one?

@rafariossaa
Copy link
Contributor

Hi,
Sorry for the long delay.
Sure !! We are hesitant to receive PRs fixing or adding features.
Please, feel free to send a PR we will be glad to review and merge it.
Thanks

@carrodher carrodher removed the on-hold Issues or Pull Requests with this label will never be considered stale label Jul 10, 2023
@github-actions
Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Jul 26, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Aug 1, 2023
@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved spring-cloud-dataflow stale 15 days without activity tech-issues The user has a technical issue about an application
Projects
None yet
Development

No branches or pull requests

5 participants