Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] fix: add missing api-approved.kubernetes.io annotation to CRD #27893

Closed
wants to merge 5 commits into from

Conversation

woehrl01
Copy link

@woehrl01 woehrl01 commented Jul 11, 2024

Description of the change

Adds missing annotation api-approved.kubernetes.io to CRD, which prevents creation of the CRD if missing because of the k8s.io namespace

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added external-dns triage Triage is needed labels Jul 11, 2024
@github-actions github-actions bot requested a review from carrodher July 11, 2024 07:52
@woehrl01 woehrl01 changed the title [bitnami/external-dns] fix: add missing api-approved.kubernetes.io an… [bitnami/external-dns] fix: add missing api-approved.kubernetes.io annotation to CRD Jul 11, 2024
woehrl01 and others added 2 commits July 11, 2024 09:56
Signed-off-by: Lukas Wöhrl <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jul 11, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jul 11, 2024
@github-actions github-actions bot removed the request for review from carrodher July 11, 2024 16:13
@github-actions github-actions bot requested a review from jotamartos July 11, 2024 16:13
@jetersen
Copy link
Contributor

@jotamartos
Copy link
Contributor

jotamartos commented Jul 16, 2024

Hi @woehrl01,

Thank you for taking the time to create this PR. As you mentioned, there is a similar PR in #27434 and as we mentioned there, CRDs are updated automatically once a new version is released. If we merge this change, it will be automatically removed during the next release of the Bitnami package. You will need to wait for the upstream project to release a new version with the updated CRD for this to be included in the chart.

Thanks

@woehrl01
Copy link
Author

@jetersen @jotamartos thank you, I understand.

Carlos Rodríguez Hernández and others added 2 commits July 19, 2024 12:48
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@jotamartos
Copy link
Contributor

Closing this PR as there is another one applying the same changes #27434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants