-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/external-dns] fix: add missing api-approved.kubernetes.io annotation to CRD #27893
Conversation
…notation to CRD Signed-off-by: Lukas Wöhrl <[email protected]>
Signed-off-by: Lukas Wöhrl <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Hi @woehrl01, Thank you for taking the time to create this PR. As you mentioned, there is a similar PR in #27434 and as we mentioned there, CRDs are updated automatically once a new version is released. If we merge this change, it will be automatically removed during the next release of the Bitnami package. You will need to wait for the upstream project to release a new version with the updated CRD for this to be included in the chart. Thanks |
@jetersen @jotamartos thank you, I understand. |
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Closing this PR as there is another one applying the same changes #27434. |
Description of the change
Adds missing annotation
api-approved.kubernetes.io
to CRD, which prevents creation of the CRD if missing because of the k8s.io namespaceBenefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm