Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow 't' and 'amount' parameters in the same URI #2

Closed
jonas-lundqvist opened this issue Jun 3, 2023 · 1 comment
Closed

Comments

@jonas-lundqvist
Copy link

From the Telegram group:

I think the validation should produce an error if both t and amount are present in the same URI. If a token aware wallet is requesting a specific BCH amount and needs backwards compatibility that wallet should drop the t parameter since that request obviously can't contain tokens.

@bitjson
Copy link
Owner

bitjson commented Jun 16, 2023

Thanks for opening the issue! Agreed: this would almost certainly be an implementation bug, and clients should error as strictly as possible to maximize future upgrade possibilities.

Fixed in 68f0f27 🚀

@bitjson bitjson closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants