Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Android SyncResult by custom result #886

Closed
rfc2822 opened this issue Jul 4, 2024 · 1 comment · Fixed by #1094
Closed

Replace Android SyncResult by custom result #886

rfc2822 opened this issue Jul 4, 2024 · 1 comment · Fixed by #1094
Assignees
@sunkup
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Jul 4, 2024 •
edited
Loading

We're currently using SyncResult (from Android sync framework) for historical reasons. There are several "workarounds" to map conditions to SyncResults.

Because we now use workers instead of the sync framework, we should have our own result class.

Depends on #896
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jul 4, 2024
@rfc2822 rfc2822 mentioned this issue Jul 4, 2024
Open
3 tasks
@github-actions github-actions bot removed the dependent label Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

This PR/issue depends on:

@sunkup sunkup linked a pull request Oct 22, 2024 that will close this issue
Replace android sync framework result class with our own #1094
Merged
4 tasks
@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Oct 23, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunkup sunkup

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace android sync framework result class with our own bitfireAT/davx5-ose
2 participants
@rfc2822 @sunkup