Exception on Python 3.9

[rokups]

Issue type

• bug
• missing functionality
• performance
• feature request

Brief description

  File "/home/rk/src/bfx/venv/lib/python3.9/site-packages/websockets/protocol.py", line 911, in write_frame
    with (yield from self._drain_lock):
TypeError: 'Lock' object is not iterable

Steps to reproduce

• Execute latest version on Python 3.9

Additional Notes:

• TypeError: 'Lock' object is not iterable on py3.9 python-websockets/websockets#760
• Issue is fixed by updating websockets module to latest version.

[itsdeka]

Thank you very much for reporting this issue.
I'll open a PR soon.

[itsdeka]

I tried to upgrade websockets to 8.1 and there are issues with running tests/ws/* files. Are you able to run those?

[rokups]

O didn't try tests, but there were some other warnings and backtesting live didn't work. But at least exceptions went away.

…

On February 18, 2021 18:15:57 Dario Moceri ***@***.***> wrote: I tried to upgrade websockets to 8.1 and there are issues with running tests/ws/* files. Are you able to run those? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ftwornot]

Why not simply change websockets version in requirements.txt from 7.0 to 8.1. At least that worked for me although I had installed 7.0 first. (honest question)

[imankulov]

Hey there! I can see that the issue has been fixed in c755d33. @itsdeka, I would appreciate if you could release a new version with the fix on PyPI. Thanks!

[itsdeka]

Thank you all, done @imankulov

[PsykotropyK]

Hello.
I installed the package by cloning the repo & while the setup.py references websockets 8.1 and this is the version I have installed, I have the same issue.
Complete stack trace is

Traceback (most recent call last):
File "D:\Apps\Python\Python39\lib\site-packages\bitfinex_api_py-1.1.14-py3.9.egg\bfxapi\websockets\generic_websocket.py", line 143, in _run_socket
File "D:\Apps\Python\Python39\lib\site-packages\bitfinex_api_py-1.1.14-py3.9.egg\bfxapi\websockets\bfx_websocket.py", line 477, in on_message
File "D:\Apps\Python\Python39\lib\site-packages\bitfinex_api_py-1.1.14-py3.9.egg\bfxapi\websockets\bfx_websocket.py", line 208, in _ws_system_handler
File "D:\Apps\Python\Python39\lib\site-packages\bitfinex_api_py-1.1.14-py3.9.egg\bfxapi\websockets\bfx_websocket.py", line 242, in _system_info_handler
File "D:\Apps\Python\Python39\lib\site-packages\bitfinex_api_py-1.1.14-py3.9.egg\bfxapi\websockets\bfx_websocket.py", line 501, in on_open
File "D:\Apps\Python\Python39\lib\site-packages\bitfinex_api_py-1.1.14-py3.9.egg\bfxapi\websockets\bfx_websocket.py", line 492, in _ws_authenticate_socket
File "D:\Apps\Python\Python39\lib\site-packages\bitfinex_api_py-1.1.14-py3.9.egg\bfxapi\websockets\generic_websocket.py", line 56, in send
File "D:\Apps\Python\Python39\lib\site-packages\websockets\protocol.py", line 467, in send
yield from self.write_frame(True, OP_TEXT, data.encode('utf-8'))
File "D:\Apps\Python\Python39\lib\site-packages\websockets\protocol.py", line 911, in write_frame
with (yield from self._drain_lock):
TypeError: 'Lock' object is not iterable